Skip to content

[CI] Skip flaky firebase_performance driver tests #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_performance/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.1+4

* Skip flaky driver tests.

## 0.3.1+3

* Fixed analyzer warnings about unused fields.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ void main() {
});
});

// TODO(kroikie): Update flaky test and remove skip parameter
// https://github.com/FirebaseExtended/flutterfire/issues/1454.
group('$Trace', () {
Trace testTrace;

Expand Down Expand Up @@ -114,8 +116,10 @@ void main() {
completion(<String, String>{'yugi': 'oh'}),
);
});
});
}, skip: true);

// TODO(kroikie): Update flaky test and remove skip parameter
// https://github.com/FirebaseExtended/flutterfire/issues/1454.
group('$HttpMetric', () {
HttpMetric testMetric;

Expand Down Expand Up @@ -177,6 +181,6 @@ void main() {

await pumpEventQueue();
});
});
}, skip: true);
});
}
2 changes: 1 addition & 1 deletion packages/firebase_performance/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Google Performance Monitoring for Firebase, an a
iOS.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_performance
version: 0.3.1+3
version: 0.3.1+4

dependencies:
flutter:
Expand Down