Skip to content

[firebase_auth] [firebase_in_app_messaging] Update example apps with correct const constructors. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_auth/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.14.0+6

* Update example app with correct const constructors.

## 0.14.0+5

* On iOS, `fetchSignInMethodsForEmail` now returns an empty list when the email
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_auth/example/lib/register_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class RegisterPageState extends State<RegisterPage> {
children: <Widget>[
TextFormField(
controller: _emailController,
decoration: InputDecoration(labelText: 'Email'),
decoration: const InputDecoration(labelText: 'Email'),
validator: (String value) {
if (value.isEmpty) {
return 'Please enter some text';
Expand All @@ -42,7 +42,7 @@ class RegisterPageState extends State<RegisterPage> {
),
TextFormField(
controller: _passwordController,
decoration: InputDecoration(labelText: 'Password'),
decoration: const InputDecoration(labelText: 'Password'),
validator: (String value) {
if (value.isEmpty) {
return 'Please enter some text';
Expand Down
32 changes: 16 additions & 16 deletions packages/firebase_auth/example/lib/signin_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ class SignInPageState extends State<SignInPage> {
onPressed: () async {
final FirebaseUser user = await _auth.currentUser();
if (user == null) {
Scaffold.of(context).showSnackBar(SnackBar(
content: const Text('No one has signed in.'),
Scaffold.of(context).showSnackBar(const SnackBar(
content: Text('No one has signed in.'),
));
return;
}
Expand Down Expand Up @@ -93,7 +93,7 @@ class _EmailPasswordFormState extends State<_EmailPasswordForm> {
),
TextFormField(
controller: _emailController,
decoration: InputDecoration(labelText: 'Email'),
decoration: const InputDecoration(labelText: 'Email'),
validator: (String value) {
if (value.isEmpty) {
return 'Please enter some text';
Expand All @@ -103,7 +103,7 @@ class _EmailPasswordFormState extends State<_EmailPasswordForm> {
),
TextFormField(
controller: _passwordController,
decoration: InputDecoration(labelText: 'Password'),
decoration: const InputDecoration(labelText: 'Password'),
validator: (String value) {
if (value.isEmpty) {
return 'Please enter some text';
Expand Down Expand Up @@ -238,7 +238,7 @@ class _EmailLinkSignInSectionState extends State<_EmailLinkSignInSection>
),
TextFormField(
controller: _emailController,
decoration: InputDecoration(labelText: 'Email'),
decoration: const InputDecoration(labelText: 'Email'),
validator: (String value) {
if (value.isEmpty) {
return 'Please enter your email.';
Expand Down Expand Up @@ -466,8 +466,8 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
),
TextFormField(
controller: _phoneNumberController,
decoration:
InputDecoration(labelText: 'Phone number (+x xxx-xxx-xxxx)'),
decoration: const InputDecoration(
labelText: 'Phone number (+x xxx-xxx-xxxx)'),
validator: (String value) {
if (value.isEmpty) {
return 'Phone number (+x xxx-xxx-xxxx)';
Expand All @@ -487,7 +487,7 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
),
TextField(
controller: _smsController,
decoration: InputDecoration(labelText: 'Verification code'),
decoration: const InputDecoration(labelText: 'Verification code'),
),
Container(
padding: const EdgeInsets.symmetric(vertical: 16.0),
Expand Down Expand Up @@ -534,9 +534,8 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {

final PhoneCodeSent codeSent =
(String verificationId, [int forceResendingToken]) async {
widget._scaffold.showSnackBar(SnackBar(
content:
const Text('Please check your phone for the verification code.'),
widget._scaffold.showSnackBar(const SnackBar(
content: Text('Please check your phone for the verification code.'),
));
_verificationId = verificationId;
};
Expand Down Expand Up @@ -613,7 +612,7 @@ class _OtherProvidersSignInSectionState
groupValue: _selection,
onChanged: _handleRadioButtonSelected,
),
Text(
const Text(
'Github',
style: TextStyle(fontSize: 16.0),
),
Expand All @@ -622,7 +621,7 @@ class _OtherProvidersSignInSectionState
groupValue: _selection,
onChanged: _handleRadioButtonSelected,
),
Text(
const Text(
'Facebook',
style: TextStyle(
fontSize: 16.0,
Expand All @@ -633,7 +632,7 @@ class _OtherProvidersSignInSectionState
groupValue: _selection,
onChanged: _handleRadioButtonSelected,
),
Text(
const Text(
'Twitter',
style: TextStyle(fontSize: 16.0),
),
Expand All @@ -642,13 +641,14 @@ class _OtherProvidersSignInSectionState
),
TextField(
controller: _tokenController,
decoration: InputDecoration(labelText: 'Enter provider\'s token'),
decoration:
const InputDecoration(labelText: 'Enter provider\'s token'),
),
Container(
child: _showAuthSecretTextField
? TextField(
controller: _tokenSecretController,
decoration: InputDecoration(
decoration: const InputDecoration(
labelText: 'Enter provider\'s authTokenSecret'),
)
: null,
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
like Google, Facebook and Twitter.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth
version: 0.14.0+5
version: 0.14.0+6

flutter:
plugin:
Expand Down
4 changes: 4 additions & 0 deletions packages/firebase_in_app_messaging/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.0.1+4

* Update example app with correct const constructors.

## 0.0.1+3

* Update AGP, gradle and inappmessaging-display versions on Android.
Expand Down
13 changes: 6 additions & 7 deletions packages/firebase_in_app_messaging/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class ProgrammaticTriggersExample extends StatelessWidget {
padding: const EdgeInsets.all(24.0),
child: Column(
children: <Widget>[
Text(
const Text(
"Programmatic Trigger",
style: TextStyle(
fontStyle: FontStyle.italic,
Expand All @@ -61,8 +61,8 @@ class ProgrammaticTriggersExample extends StatelessWidget {
RaisedButton(
onPressed: () {
fiam.triggerEvent('chicken_event');
Scaffold.of(context).showSnackBar(SnackBar(
content: const Text("Triggering event: chicken_event")));
Scaffold.of(context).showSnackBar(const SnackBar(
content: Text("Triggering event: chicken_event")));
},
color: Colors.blue,
child: Text(
Expand Down Expand Up @@ -92,7 +92,7 @@ class AnalyticsEventExample extends StatelessWidget {
padding: const EdgeInsets.all(24.0),
child: Column(
children: <Widget>[
Text(
const Text(
"Log an analytics event",
style: TextStyle(
fontStyle: FontStyle.italic,
Expand All @@ -105,9 +105,8 @@ class AnalyticsEventExample extends StatelessWidget {
RaisedButton(
onPressed: () {
_sendAnalyticsEvent();
Scaffold.of(context).showSnackBar(SnackBar(
content:
const Text("Firing analytics event: awesome_event")));
Scaffold.of(context).showSnackBar(const SnackBar(
content: Text("Firing analytics event: awesome_event")));
},
color: Colors.blue,
child: Text(
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_in_app_messaging/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: firebase_in_app_messaging
description: Flutter plugin for Firebase In-App Messaging.
version: 0.0.1+3
version: 0.0.1+4
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_in_app_messaging

Expand Down