Skip to content

[firebase_core] v2 embedding API #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 22, 2019

Conversation

bparrishMines
Copy link
Contributor

Description

Fixes flutter/flutter#41869

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines requested review from collinjackson and removed request for collinjackson October 7, 2019 21:03
Copy link

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some comments. We should update version before merging in.

@bparrishMines bparrishMines changed the title [firebase_core] v2 embedding API [WIP] [firebase_core] v2 embedding API Oct 15, 2019
@bparrishMines bparrishMines changed the title [WIP] [firebase_core] v2 embedding API [firebase_core] v2 embedding API Oct 16, 2019
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for including an integration test!

If you add an example/test_driver/firebase_core_e2e_test.dart, CI will eventually run the integration test on iOS also. But this isn't hooked up yet, so it's optional.

@mklim mklim self-assigned this Oct 21, 2019
Copy link

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself LG, just some comments on AndroidX/Gradle changes.

Copy link

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one Javadoc nit.

@bparrishMines bparrishMines merged commit 86542f6 into firebase:master Oct 22, 2019
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
@bparrishMines bparrishMines deleted the firebase_core_embedding branch March 17, 2020 17:17
@firebase firebase locked and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_core] Support the v2 Android embedder plugins API
6 participants