Skip to content

feat(app-installations): web v9 SDK implementation #9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 30, 2022

Description

See title.

Blocked

Cannot get a working web script for app-installations from gstatic: (https://www.gstatic.com/firebasejs/9.8.4/firebase-installations.js). We won't be releasing until this is fixed.

Tried getting from NPM and hosting privately but it doesn't have the correct imports (https://storage.googleapis.com/static.invertase.io/firebasejs/9.8.4/installations.js).

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Jul 4, 2022
@russellwheatley
Copy link
Member Author

firebase-installations script is not available via gstatic server (https://www.gstatic.com/firebasejs/9.8.4/firebase-installations.js) We tried building installations custom script using typescript compiled code in the node modules but it wasn't working as it was importing from other dependencies within node modules. We attempted to add to custom script but something was still breaking. We could continue to try or wait for script to become available on gstatic server depending on timeframe.

@russellwheatley russellwheatley removed the blocked: do-not-merge PR blocked externally label Jul 4, 2022
@russellwheatley
Copy link
Member Author

We've decided to move ahead with merging this into v9/core. We will not be releasing until the installations script is available on the gstatic server.

@russellwheatley russellwheatley marked this pull request as ready for review July 4, 2022 14:29
@russellwheatley russellwheatley merged commit f7bc21b into v9/core Jul 4, 2022
@russellwheatley russellwheatley deleted the v9/app-installations branch July 4, 2022 14:29
@firebase firebase locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants