fix(firebase_messaging, iOS): ensure initial notification was tapped to open app. fixes getInitialMessage() & onMessageOpenedApp() .
#9315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sageOpenedApp firing when notification tapped from terminated state
russellwheatley
changed the title
getInitialMessage().getInitialMessage() & onMessageOpenedApp() .
Salakar
reviewed
Aug 9, 2022
packages/firebase_messaging/firebase_messaging/ios/Classes/FLTFirebaseMessagingPlugin.m
Outdated
Show resolved
Hide resolved
…FirebaseMessagingPlugin.m Co-authored-by: Mike Diarmid <[email protected]>
Salakar
approved these changes
Aug 10, 2022
Ehesp
approved these changes
Aug 10, 2022
erdemyerebasmaz
added a commit
to breez/breezmobile
that referenced
this pull request
Aug 16, 2022
anytime: - bottomPadding of view is added into consideration when placing Up Next bottom sheet and snackbar notifications - Bug fixes: URL launches now call external app rather than webview; fix position slider on iOS; fix now playing restart bug on queue; fix OPML export label on English. firebase_messaging: - FIX: ensure initial notification was tapped to open app. fixes getInitialMessage() & onMessageOpenedApp() . ([#9315](firebase/flutterfire#9315)). ([e66c59ca](firebase/flutterfire@e66c59c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the scenario where a push notification is sent but the user presses the app icon to open app. This PR ensures that the notification that was tapped to open the app is the RemoteMessage from
getInitialMessage().This also fixes
onMessageOpenedAppwhich was opening the app when tapping a notification from a terminated state.I've also discovered that when the app is in a terminated state and a push notification is sent, the
initState()andbuild()functions within the Flutter application are called before the app has been opened. Therefore, thegetInitialMessage()cannot be put intoinitState(). Otherwise, theRemoteMessagereturned fromgetInitialMessage()will benullas it is not known whether the app was opened via notification yet.This bug is being tracked here: #6517
Related Issues
fixes #4188
fixes #8979
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?