Skip to content

test(cloud_firestore, android): skip end 2 end test that is timing out on CI #9361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Aug 16, 2022

Description

Fixing Firestore android e2e test that is timing out on the CI. It does work locally.

Created an issue to start tracking skipped e2e tests: #9375

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the type: infrastructure Improvements to the codebase label Aug 16, 2022
@russellwheatley russellwheatley marked this pull request as draft August 16, 2022 11:08
@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Aug 16, 2022
@russellwheatley russellwheatley removed the blocked: do-not-merge PR blocked externally label Aug 17, 2022
@russellwheatley russellwheatley changed the title test(firestore): skip test that is timing out test(cloud_firestore, android): skip end 2 end test that is timing out on CI Aug 17, 2022
@russellwheatley russellwheatley marked this pull request as ready for review August 17, 2022 10:16
@russellwheatley russellwheatley merged commit 4591d72 into master Aug 18, 2022
@russellwheatley russellwheatley deleted the @russell/emulator-update branch August 18, 2022 08:50
@firebase firebase locked and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: infrastructure Improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants