Adding Java samples for listUsersAsync() and setCustomUserClaimsAsync() #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Nov 29, 2017
| // [START verify_custom_claims] | ||
| // Verify the ID token first. | ||
| FirebaseToken decoded = FirebaseAuth.getInstance().verifyIdTokenAsync(idToken).get(); | ||
| if (Boolean.TRUE.equals(decoded.getClaims().get("admin"))) { |
There was a problem hiding this comment.
Boolean.TRUE.equals seems a bit strange. Why not just if(decoded.getClaims().get("admin"))
There was a problem hiding this comment.
getClaims() returns a Map<String, Object>. So when querying the map we need to deal with possible null values (if the key does not exist), and the returned value not being boolean. Boolean.TRUE.equals() provides a one-liner that deals with both cases.
samtstern
reviewed
Nov 29, 2017
| .getUserByEmailAsync("[email protected]").get(); | ||
| // Add incremental custom claim without overwriting the existing claims. | ||
| Map<String, Object> currentClaims = user.getCustomClaims(); | ||
| if (Boolean.TRUE.equals(currentClaims.get("admin"))) { |
samtstern
approved these changes
Nov 29, 2017
|
SGTM!
…On Tue, Nov 28, 2017, 6:33 PM Hiranya Jayathilaka ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In auth/src/main/java/com/google/firebase/quickstart/AuthSnippets.java
<#15 (comment)>
:
> + public static void setCustomUserClaims(
+ String uid) throws InterruptedException, ExecutionException {
+ // [START set_custom_user_claims]
+ // Set admin privilege on the user corresponding to uid.
+ Map<String, Object> claims = new HashMap<>();
+ claims.put("admin", true);
+ FirebaseAuth.getInstance().setCustomClaimsAsync(uid, claims).get();
+ // The new custom claims will propagate to the user's ID token the
+ // next time a new one is issued.
+ // [END set_custom_user_claims]
+
+ String idToken = "id_token";
+ // [START verify_custom_claims]
+ // Verify the ID token first.
+ FirebaseToken decoded = FirebaseAuth.getInstance().verifyIdTokenAsync(idToken).get();
+ if (Boolean.TRUE.equals(decoded.getClaims().get("admin"))) {
getClaims() returns a Map<String, Object>. So when querying the map we
need to deal with possible null values (if the key does not exist), and the
returned value not being boolean. Boolean.TRUE.equals() provides a
one-liner that deals with both cases.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEw6mJV64cRcBn2PbX93g9HB_6mgepRks5s7KZPgaJpZM4QuJak>
.
|
avishalom
approved these changes
Dec 7, 2017
| @@ -155,6 +232,8 @@ public static void main(String[] args) throws InterruptedException, ExecutionExc | |||
| getUserByEmail("[email protected]"); | |||
| getUserByPhoneNumber("+11234567890"); | |||
| updateUser("some-uid"); | |||
| //setCustomUserClaims("some-uid"); | |||
There was a problem hiding this comment.
Is this commented out on purpose ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to firebase/firebase-admin-java#92
Samples to appear on https://firebase.google.com/docs/auth/admin/custom-claims and https://firebase.google.com/docs/auth/admin/manage-users