Align the comments in the check revoked (verify id token) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
suggested changes
Feb 14, 2018
| // Token is invalid. | ||
| } catch (ExecutionException e) { | ||
| if (e.getCause() instanceof FirebaseAuthException) { | ||
| if ( ((FirebaseAuthException) e.getCause()).getErrorCode().equals("id-token-revoked")) { |
There was a problem hiding this comment.
Break into a couple of lines:
FirebaseAuthException authError = ...;
| @@ -240,7 +243,7 @@ public static void revokeIdTokens(String idToken) throws InterruptedException, E | |||
|
|
|||
| // [START save_revocation_in_db] | |||
| DatabaseReference ref = FirebaseDatabase.getInstance().getReference("metadata/" + uid); | |||
| ref.setValueAsync(MapBuilder.of("revokeTime", revocationSecond)).get(); | |||
| ref.setValueAsync(ImmutableMap.<String, Object>of("revokeTime", revocationSecond)).get(); | |||
There was a problem hiding this comment.
Just use HashMap here. ImmutableMap is a guava type and I don't think we want it to appear in snippets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.