Skip to content

Move firebase/testing to firebase/rules-unit-testing #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Move firebase/testing to firebase/rules-unit-testing #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2699726
Move firebase/testing to firebase/rules-unit-testing
samtstern Aug 26, 2020
a04ab81
Tests no longer hang
samtstern Aug 26, 2020
9bfb6f9
Print coverage reports
samtstern Aug 26, 2020
3b92b0d
Update rules-unit-testing to 1.0.2
samtstern Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
node_modules
*.log
*.log
*-coverage.html
.DS_Store
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The repository is broken up by testing strategy:

* **[Unit testing security rules](unit-test-security-rules/README.md)** -
write unit tests for your Realtime Database and Cloud Firestore security
rules using `mocha` and the `@firebase/testing` library.
rules using `mocha` and the `@firebase/rules-unit-testing` library.
* **[Unit testing Cloud Functions](unit-test-cloud-functions/README.md)** -
write unit tests for your Cloud Functions usiing the `firebase-functions-test` SDK.
* **[Connect your app to the Emulator Suite](manual-emulator-testing/README.md)** -
Expand All @@ -25,4 +25,4 @@ See [LICENSE](LICENSE)
[![Actions Status][gh-actions-badge]][gh-actions]

[gh-actions]: https://github.com/firebase/quickstart-testing/actions
[gh-actions-badge]: https://github.com/firebase/quickstart-testing/workflows/CI%20Tests/badge.svg
[gh-actions-badge]: https://github.com/firebase/quickstart-testing/workflows/CI%20Tests/badge.svg
2,081 changes: 956 additions & 1,125 deletions cs-walkthrough/functions/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions cs-walkthrough/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@
"start": "npm run shell",
"deploy": "firebase deploy --only functions",
"logs": "firebase functions:log",
"test": "mocha --timeout 5000"
"test": "mocha --timeout 5000 --exit"
},
"engines": {
"node": "8"
"node": "10"
},
"dependencies": {
"file-system": "^2.2.2",
"firebase-admin": "^8.13.0",
"firebase-functions": "^3.7.0"
"firebase-admin": "^9.1.1",
"firebase-functions": "^3.11.0"
},
"devDependencies": {
"@firebase/testing": "^0.20.5",
"@firebase/rules-unit-testing": "^1.0.2",
"eslint": "^5.12.0",
"eslint-plugin-promise": "^4.0.1",
"firebase-functions-test": "^0.2.1",
Expand Down
2 changes: 1 addition & 1 deletion cs-walkthrough/functions/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const TEST_FIREBASE_PROJECT_ID = "test-firestore-rules-project";
// TODO: Change this to your real Firebase Project ID
const REAL_FIREBASE_PROJECT_ID = "changeme";

const firebase = require("@firebase/testing");
const firebase = require("@firebase/rules-unit-testing");

const seedItems = {
"chocolate": 4.99,
Expand Down
2 changes: 1 addition & 1 deletion cs-walkthrough/functions/test_all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const path = require("path");
const FIREBASE_PROJECT_ID = "something"
const TEST_FIREBASE_PROJECT_ID = "test-firestore-rules-project";

const firebase = require("@firebase/testing");
const firebase = require("@firebase/rules-unit-testing");

const seedItems = {
"chocolate": 4.99,
Expand Down
Loading