-
Notifications
You must be signed in to change notification settings - Fork 15
Add code samples for Remote Config operations #9
Conversation
@lahirumaramba LGTM, I assume the CI failures are because the SDK has not released yet? Please wait until CI is green to merge these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@samtstern Thanks! Yes, the current SDK the project is pointing to does not have the new RC features, hence the CI failures. Once the SDK is released, do you think I should update |
@lahirumaramba yep exactly, if you bump the dependency in this PR as well then it will be green before you merge. If these snippets have to appear in docs via |
Sam's right about git_revision, but it comes with a caveat: you can't use the newer, registry-based named snippets with that flag. So I'd resist that unless there's a big rush. |
@egilmorez actually |
Check you guys out! I'll try that today; I'm an excellent test for ease-of-use criteria :D |
@samtstern @hiranya911 : |
Related to: fix: Cleaning up FirebaseApp state management firebase-admin-java#476
Samples to appear on https://firebase.google.com/docs/remote-config/automate-rc and https://firebase.google.com/docs/remote-config/templates