[Misc.] Add activations for non-cuda Backends #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuan1i
changed the title
zhiyuan1i
changed the title
zhiyuan1i
force-pushed
the
main
branch
7 times, most recently
from
f15434c to
e828f2b
Compare
zhiyuan1i
force-pushed
the
main
branch
6 times, most recently
from
cbd196d to
6b673e6
Compare
zhiyuan1i
force-pushed
the
main
branch
6 times, most recently
from
aacf017 to
0d815aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is behind #163
This PR aims to address the issue that the previous activation functions couldn't be used on non-CUDA - like devices. So in this PR, if there is a native PyTorch implementation, we use the one provided by PyTorch. If not, we use the implementation with Triton. I've added relevant tests in the PR and ensured that all the tests have passed. If there is a need to implement naive PyTorch, comments are welcome.