Fix hasAlternateReturn regression #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The segfault was caused by the moving of
hasAlternateReturns
afterGetCalleeAndArguments
call. While it looked identical, it was not becauseGetCalleeAndArguments
actually moved theanalyzer.GetActuals()
.https://github.com/llvm/llvm-project/blob/05756e6937d58c357b0b7e37ff3e9a8f7dd0d485/flang/lib/Semantics/expression.cpp#L1869
This later caused
procRef.hasAlternateReturns()
calls to return true on thing that were not alternate return calls, and a selectOp to be created with no target blocks, hence the segfault.Just use
callee->arguments
where the arguments were moved to instead.I pushing here to fix fir-dev, but this will need re-upstreaming in LLVM.