[flang][openacc] Lower enter data directive #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementval
force-pushed
the
flang/openacc/lower/op/enter_data
branch
from
75c4272 to
710f164
Compare
schweitzpgi
approved these changes
Oct 28, 2020
flang/lib/Lower/OpenACC.cpp
Outdated
| mlir::Location loc, | ||
| const SmallVectorImpl<Value> &operands, | ||
| const SmallVectorImpl<int32_t> &operandSegments) { | ||
| llvm::ArrayRef<mlir::Type> argTy; |
There was a problem hiding this comment.
Should argTy be set to something before being used?
clementval
force-pushed
the
flang/openacc/lower/op/enter_data
branch
from
710f164 to
2a60ebf
Compare
clementval
force-pushed
the
flang/openacc/lower/op/enter_data
branch
2 times, most recently
from
f1018a4 to
00afb89
Compare
|
@schweitzpgi Just updated the PR to resolve conflicts and address your comments |
clementval
force-pushed
the
flang/openacc/lower/op/enter_data
branch
from
00afb89 to
4667b0b
Compare
This was referenced Oct 30, 2020
clementval
added a commit
to llvm/llvm-project
that referenced
this pull request
Nov 4, 2020
This patch upstream the lowering of Enter Data directive that was initially done in flang-compiler#526 Reviewed By: schweitz Differential Revision: https://reviews.llvm.org/D90470
chelini
pushed a commit
to llvm/Polygeist
that referenced
this pull request
Nov 25, 2020
This patch upstream the lowering of Enter Data directive that was initially done in flang-compiler/f18-llvm-project#526 Reviewed By: schweitz Differential Revision: https://reviews.llvm.org/D90470
arichardson
pushed a commit
to arichardson/llvm-project
that referenced
this pull request
Mar 25, 2021
This patch upstream the lowering of Enter Data directive that was initially done in flang-compiler/f18-llvm-project#526 Reviewed By: schweitz Differential Revision: https://reviews.llvm.org/D90470
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
This patch upstream the lowering of Enter Data directive that was initially done in flang-compiler/f18-llvm-project#526 Reviewed By: schweitz Differential Revision: https://reviews.llvm.org/D90470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.