[NFC] Remove old BoxValue class and rename IrBoxValue to BoxValue #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonaldson
approved these changes
Mar 11, 2021
schweitzpgi
reviewed
Mar 11, 2021
jeanPerier
force-pushed
the
jp-boxvalue-clean-up
branch
from
50bbefc to
c9d5579
Compare
schweitzpgi
approved these changes
Mar 16, 2021
| @@ -404,6 +358,9 @@ class MutableBoxValue : public AbstractIrBox { | |||
| MutableProperties mutableProperties; | |||
| }; | |||
|
|
|||
| /// Used for triple notation (array slices) | |||
| using RangeBoxValue = std::tuple<mlir::Value, mlir::Value, mlir::Value>; | |||
There was a problem hiding this comment.
Is this still used? (I thought we had removed it a while back.)
There was a problem hiding this comment.
Yes, it is still used around subscript-triplet lowering here:
It is a very localized use, so the definition could also be moved to ConvertExpr.cpp to avoid being exported in a public header.
Also make AbstractIrBox inherit from AbstractArrayBox to get the array aspects from there.
jeanPerier
force-pushed
the
jp-boxvalue-clean-up
branch
from
c9d5579 to
67cfbeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note there is a tiny bug fix in
BoxValue::verify, I could not help noticing the&&instead of||while reading the comments in the updated. Apart from that, sed did most of this PR.After this PR, remaining clean-up around extended values that I see:
Unboxed/ArrayBoxValue. Should we officially use them for non polymorphic derive types with no length parameters (F95 derived types) ? If yes, some comments/names need to be updated (e.gSymbolBox::Intrinsic). If not, may want new extended value category for them.