[flang] Adding ability to customize the printer of the LLVMIRLoweringPass #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaud-K
changed the title
schweitzpgi
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have the ability to customize the printer in the LLVMIRLoweringPass in order to just print the global variable initializations in the flange flow.
Currently, the pass does 2 things, it lowers and prints with a hardcoded llvmModule->print(output, nullptr)
I started with my own copy of LLVMIRLoweringPass and just changed the part that does the printing to meet my needs but maybe we can avoid the cut-and-paste.
To that end, I am adding an extra argument to the creation of the pass which is an optional printer. If none is provided a default is created to do what it currently does (llvmModule->print(output, nullptr)). This way the client code does need to change.