misc: cleanup #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

yzh119 merged 4 commits into flashinfer-ai:main from bzhng-development:fix-various-issues

May 25, 2025

Contributor

b8zhong commented May 25, 2025

📌 Description

Short unused import code cleanup

🔍 Related Issues

N/A

✅ Pre-commit Checks

I have installed pre-commit by running pip install pre-commit (or used your preferred method).
I have installed the hooks with pre-commit install.
I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

b8zhong added 4 commits

May 25, 2025 14:24


          fix: various ruff warnings

e2247b3


          fix: various ruff warnings

e460477


          fix: various ruff warnings

a22e1f6


          fix: various ruff warnings

28573ab

yzh119 approved these changes

View reviewed changes

Collaborator

yzh119 left a comment

LGTM, thank you for the contribution!

yzh119 merged commit e5cfd6d into flashinfer-ai:main

2 checks passed

Collaborator

yzh119 commented May 25, 2025

A next step could be using ruff as pre-commit hook instead of isort (as suggested by @abcdabcd987 ).

b8zhong added a commit to bzhng-development/flashinfer that referenced this pull request


          followup of flashinfer-ai#1092 remove unused followup

8d9dd9d

b8zhong added a commit to bzhng-development/flashinfer that referenced this pull request


          followup of flashinfer-ai#1092 remove unused followup

fea7df6

b8zhong mentioned this pull request

misc: followup #1093

Merged

yzh119 pushed a commit that referenced this pull request


          misc: unused import followup (#1093)

266aa02

Followup of #1092

The last one.


Additionally @yzh119 I didn't fix the below unused imports, I am not
sure if it will break the build.

```
flashinfer/jit/attention/__init__.py:17:15: F401 `.pytorch` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
   |
15 | """
16 |
17 | from . import pytorch, tvm
   |               ^^^^^^^ F401
18 | from .pytorch import gen_batch_decode_mla_module as gen_batch_decode_mla_module
19 | from .pytorch import gen_batch_decode_module as gen_batch_decode_module
   |
   = help: Use an explicit re-export: `pytorch as pytorch`

flashinfer/jit/attention/__init__.py:17:24: F401 `.tvm` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
   |
15 | """
16 |
17 | from . import pytorch, tvm
   |                        ^^^ F401
18 | from .pytorch import gen_batch_decode_mla_module as gen_batch_decode_mla_module
19 | from .pytorch import gen_batch_decode_module as gen_batch_decode_module
   |
   = help: Use an explicit re-export: `tvm as tvm`

flashinfer/prefill.py:2664:13: F841 Local variable `module` is assigned to but never used
     |
2662 |         if args not in modules_dict:
2663 |             uri = get_batch_prefill_uri("cutlass", *args)
2664 |             module = get_fmha_module(*args)
     |             ^^^^^^ F841
2665 |
2666 |             @register_custom_op(
     |
     = help: Remove assignment to unused variable `module`

flashinfer/profiler/__init__.py:17:8: F401 `argparse` imported but unused
   |
15 | """
16 |
17 | import argparse
   |        ^^^^^^^^ F401
18 | import csv
19 | import json
   |
   = help: Remove unused import: `argparse`

flashinfer/profiler/__init__.py:18:8: F401 `csv` imported but unused
   |
17 | import argparse
18 | import csv
   |        ^^^ F401
19 | import json
20 | from collections import namedtuple
   |
   = help: Remove unused import: `csv`

flashinfer/profiler/__init__.py:19:8: F401 `json` imported but unused
   |
17 | import argparse
18 | import csv
19 | import json
   |        ^^^^ F401
20 | from collections import namedtuple
21 | from enum import Enum
   |
   = help: Remove unused import: `json`

flashinfer/profiler/__init__.py:20:25: F401 `collections.namedtuple` imported but unused
   |
18 | import csv
19 | import json
20 | from collections import namedtuple
   |                         ^^^^^^^^^^ F401
21 | from enum import Enum
22 | from typing import List
   |
   = help: Remove unused import: `collections.namedtuple`
   ```

yzh119 mentioned this pull request

[wip] ci: update pre-commits #1094

Open

5 tasks

Edenzzzz pushed a commit to Edenzzzz/flashinfer that referenced this pull request


          misc: unused import cleanup (flashinfer-ai#1092)

19998ae

<!-- .github/pull_request_template.md -->

## 📌 Description

<!-- What does this PR do? Briefly describe the changes and why they’re
needed. -->

Short unused import code cleanup

## 🔍 Related Issues

N/A

<!-- Link any related issues here -->

### ✅ Pre-commit Checks

- [x] I have installed `pre-commit` by running `pip install pre-commit`
(or used your preferred method).
- [x] I have installed the hooks with `pre-commit install`.
- [x] I have run the hooks manually with `pre-commit run --all-files`
and fixed any reported issues.

Edenzzzz pushed a commit to Edenzzzz/flashinfer that referenced this pull request


          misc: unused import followup (flashinfer-ai#1093)

81a253f

Followup of flashinfer-ai#1092

The last one.


Additionally @yzh119 I didn't fix the below unused imports, I am not
sure if it will break the build.

```
flashinfer/jit/attention/__init__.py:17:15: F401 `.pytorch` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
   |
15 | """
16 |
17 | from . import pytorch, tvm
   |               ^^^^^^^ F401
18 | from .pytorch import gen_batch_decode_mla_module as gen_batch_decode_mla_module
19 | from .pytorch import gen_batch_decode_module as gen_batch_decode_module
   |
   = help: Use an explicit re-export: `pytorch as pytorch`

flashinfer/jit/attention/__init__.py:17:24: F401 `.tvm` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
   |
15 | """
16 |
17 | from . import pytorch, tvm
   |                        ^^^ F401
18 | from .pytorch import gen_batch_decode_mla_module as gen_batch_decode_mla_module
19 | from .pytorch import gen_batch_decode_module as gen_batch_decode_module
   |
   = help: Use an explicit re-export: `tvm as tvm`

flashinfer/prefill.py:2664:13: F841 Local variable `module` is assigned to but never used
     |
2662 |         if args not in modules_dict:
2663 |             uri = get_batch_prefill_uri("cutlass", *args)
2664 |             module = get_fmha_module(*args)
     |             ^^^^^^ F841
2665 |
2666 |             @register_custom_op(
     |
     = help: Remove assignment to unused variable `module`

flashinfer/profiler/__init__.py:17:8: F401 `argparse` imported but unused
   |
15 | """
16 |
17 | import argparse
   |        ^^^^^^^^ F401
18 | import csv
19 | import json
   |
   = help: Remove unused import: `argparse`

flashinfer/profiler/__init__.py:18:8: F401 `csv` imported but unused
   |
17 | import argparse
18 | import csv
   |        ^^^ F401
19 | import json
20 | from collections import namedtuple
   |
   = help: Remove unused import: `csv`

flashinfer/profiler/__init__.py:19:8: F401 `json` imported but unused
   |
17 | import argparse
18 | import csv
19 | import json
   |        ^^^^ F401
20 | from collections import namedtuple
21 | from enum import Enum
   |
   = help: Remove unused import: `json`

flashinfer/profiler/__init__.py:20:25: F401 `collections.namedtuple` imported but unused
   |
18 | import csv
19 | import json
20 | from collections import namedtuple
   |                         ^^^^^^^^^^ F401
21 | from enum import Enum
22 | from typing import List
   |
   = help: Remove unused import: `collections.namedtuple`
   ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet