Skip to content

Handling different types of data archives in release DEB #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asbytes
Copy link

@asbytes asbytes commented Oct 11, 2024

It seems that archive format in DEB release file was changed from xz to zstd. This fix is an attempt to handle any type of archive format in case if it will be changed again suddenly.
Fixes #546

@flathubbot
Copy link
Contributor

Started test build 153645

@flathubbot
Copy link
Contributor

Build 153645 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/136734/com.visualstudio.code.flatpakref

@xduugu
Copy link
Contributor

xduugu commented Oct 11, 2024

Wouldn't it be sufficient to replace data.tar.xz with data.tar*? But I'm not sure if the code needs to handle every possible compression type at all as it is quite unlikely that they will arbitrarily switch the compression between releases. At some point, they will switch to zstd, but for now, they switched back to xz in version 1.94.2 due to microsoft/vscode#230418.

@zhsj
Copy link

zhsj commented Oct 11, 2024

The code can be simplified as

bsdtar --to-stdout -xf code.deb data.* | bsdtar --no-same-owner -xf -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Upgrade From Version 1.93.1 to 1.94.0
4 participants