Skip to content

2.0.1 svelte simple modal for Svelte5 Only Rune Mode #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Neptunium1129
Copy link

  • Svelte5 only Rune mode
  • add : function ContentOutside open Mode > Maximum update depth exceeded problem
  • edit : function bind : mount is maybe bug? detail is Svelte5 migration #114
  • add : autofocus modal contents

Hi there 👋

Thank you so much for creating a PR. To streamline the process and make sure that your changes can get merged easily, please stick to the following structure. See #47 for an example of how to create an excellent PR description.

Background

Describe the context on how you use svelte-simple-modal. E.g., plain Svelte app, SvelteKit, Sapper, SSR, etc.

Currently Observed Behavior

  • detail is Svelte5 migration #114
  • Bug Fix: mount was causing component duplication when repeatedly clicked.
  • mount was causing potential duplication issues when repeatedly clicking the button

New Behavior

  • Add: ContentOutside open mode - Prevents excessive updates, which were leading to a "Maximum update depth exceeded" error.
  • Add: Autofocus support for modal content - Ensures that modal elements receive focus when opened.

- Svelte5 only Rune mode
- add : function ContentOutside open Mode > Maximum update depth exceeded problem
- edit : function bind : mount is maybe bug? detail is flekschas#114
- add : autofocus modal contents
For Test
@Neptunium1129
Copy link
Author

plz check this pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant