Skip to content

Improve Android broadcasts and iOS delegate #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 5, 2023

Conversation

mouEsam
Copy link
Contributor

@mouEsam mouEsam commented Feb 3, 2023

This PR includes a lot of improvements:

  • Flutter:
    • Encapsulate call data.
    • Improve call permissions and phone contact.
  • Android:
    • Additional call data.
    • Handle managed call UI event.
    • Add Event for failed call by system.
    • Unify API for connected incoming and outgoing call.
    • Improve Android permissions.
    • Improve call capabilities.
  • iOS:
    • Add delegate to push kit payload.
    • Export call events.

Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mouEsam
Copy link
Contributor Author

mouEsam commented Sep 5, 2023

@cloudwebrtc could you merge these changes if they are found ok?

@cloudwebrtc
Copy link
Member

Looks good, thanks for your contribution

@cloudwebrtc cloudwebrtc merged commit 50e75ba into flutter-webrtc:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants