Skip to content

Commit cb0bead

Browse files
authored
[fix] remove infinitely recursive getConfiguration call (#8141)
And out of the noise of inspection spam, comes an interesting one. Any calls to `getConfiguration()` will result in an infinite regress. ![image](https://github.com/user-attachments/assets/235cfde7-cf2e-4cd8-b3e9-7fb381b04f87) Defaulting to `super` seems like a reasonable thing to do here. --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent c0be4f1 commit cb0bead

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

flutter-idea/src/io/flutter/run/test/FlutterTestConsoleProperties.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import com.intellij.execution.Executor;
99
import com.intellij.execution.configurations.RunConfiguration;
10-
import com.intellij.execution.configurations.RunProfile;
1110
import com.intellij.execution.testframework.sm.runner.SMTRunnerConsoleProperties;
1211
import org.jetbrains.annotations.NotNull;
1312

@@ -19,9 +18,4 @@ public class FlutterTestConsoleProperties extends SMTRunnerConsoleProperties {
1918
public FlutterTestConsoleProperties(@NotNull RunConfiguration config, @NotNull Executor executor) {
2019
super(config, "FlutterWidgetTests", executor);
2120
}
22-
23-
@Override
24-
public RunProfile getConfiguration() {
25-
return getConfiguration();
26-
}
2721
}

0 commit comments

Comments
 (0)