Skip to content

[fix] remove infinitely recursive getConfiguration call #8141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 30, 2025

And out of the noise of inspection spam, comes an interesting one. Any calls to getConfiguration() will result in an infinite regress.

image

Defaulting to super seems like a reasonable thing to do here.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from jwren April 30, 2025 17:50
@pq pq merged commit cb0bead into flutter:master May 2, 2025
7 checks passed
@pq pq deleted the fix_infiniteRecursion branch May 2, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants