Skip to content

Commit cf591fc

Browse files
authored
[CQ] remove redundant throws (#8140)
From the inspection description: > Reports exceptions that are declared in a method's signature but never thrown by the method itself or its implementations and overriding methods. --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent cb0bead commit cf591fc

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

flutter-idea/src/io/flutter/view/EmbeddedBrowser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ private BrowserTab openBrowserTabFor(String tabName, ToolWindow toolWindow) thro
227227
return tab;
228228
}
229229

230-
public abstract EmbeddedTab openEmbeddedTab(ContentManager contentManager) throws Exception;
230+
public abstract EmbeddedTab openEmbeddedTab(ContentManager contentManager);
231231

232232
public void updatePanelToWidget(String widgetId) {
233233
updateUrlAndReload(devToolsUrl -> {

flutter-idea/src/io/flutter/view/EmbeddedJcefBrowser.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ public void matchIdeZoom() {
4040

4141
@Override
4242
public JComponent getTabComponent(ContentManager contentManager) {
43-
browser.getComponent().setPreferredSize(new Dimension(contentManager.getComponent().getWidth(), contentManager.getComponent().getHeight()));
43+
browser.getComponent()
44+
.setPreferredSize(new Dimension(contentManager.getComponent().getWidth(), contentManager.getComponent().getHeight()));
4445
return browser.getComponent();
4546
}
4647
}
@@ -62,7 +63,7 @@ public Logger logger() {
6263
}
6364

6465
@Override
65-
public EmbeddedTab openEmbeddedTab(ContentManager contentManager) throws Exception {
66+
public EmbeddedTab openEmbeddedTab(ContentManager contentManager) {
6667
return new EmbeddedJcefBrowserTab();
6768
}
6869
}

0 commit comments

Comments
 (0)