Derive icon previews from font files for built-in icons #5820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5735
This is the prerequisite to fixing #5723. This PR allows icons to be created from the font files distributed with the Flutter SDK. Fixing #5723 requires removing the preview icons from the plugin, not part of this PR.
Our implementation of the test framework is underpowered. This PR adds a bunch of stuff to allow very limited use of FlutterSdk, PubRoots, and PubRoot, as well as some utilities to examine the package configuration file (replacement for
.packages). It should be safe to ignore all files intestData.Disable five tests. #5821