Remove dependencies on built-in Flutter icons #5824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Oct 15, 2021
| @@ -34,4 +37,18 @@ public static JComponent getComponentOfActionEvent(@NotNull AnActionEvent e) { | |||
| public static ColorKey getEditorNotificationBackgroundColor() { | |||
| return EditorColors.GUTTER_BACKGROUND; | |||
| } | |||
|
|
|||
| @Nullable | |||
| public static Project findVisibleProject() { | |||
There was a problem hiding this comment.
This method is a bit terrifying. At minimum add a comment that this needs to only be used from the deprecated Flutter IntelliJ inspector.
Ideally, flow the project into that renderer rather than having to guess it like this.
There was a problem hiding this comment.
I share your concern. I'll add a comment in my next PR.
|
Even though there is one new failing test, I'm going to merge this as-is so it gets into the next dev channel build. I know what's wrong with the test, but don't have time to fix it today. I also know how to repair the other failing tests and plan to fix them next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.