Skip to content

Restore ignored tests #5826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 28, 2021
Merged

Restore ignored tests #5826

merged 23 commits into from
Oct 28, 2021

Conversation

stevemessick
Copy link
Member

Fixes #5821

@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@stevemessick
Copy link
Member Author

@jwren

I should restore "return null" in a few places where for debugging I changed it to throw an exception (println debugging, batch gradle style). But I'm scared to touch it today. Maybe tomorrow...

@stevemessick stevemessick requested a review from jwren October 26, 2021 16:26
This was referenced Oct 26, 2021
Merged
Closed
@stevemessick
Copy link
Member Author

Thanks for the review!

@stevemessick stevemessick merged commit 50a2172 into master Oct 28, 2021
@stevemessick stevemessick deleted the restore-tests branch October 28, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwren jwren jwren approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore disabled tests in FlutterIconLineMarkerTest
2 participants
@stevemessick @jwren