Skip to content

Fix test regex #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix test regex #5857

merged 1 commit into from
Nov 9, 2021

Conversation

stevemessick
Copy link
Member

Fixes #5852

@google-cla google-cla bot added the cla: yes label Nov 8, 2021
jwren
jwren approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, regex expressions are easy to test with unit tests, for this regex and any others in the Flutter IJ plugin, we should have/ add tests.

@stevemessick
Copy link
Member Author

I wish it were that simple.

@stevemessick stevemessick merged commit c045a53 into master Nov 9, 2021
@stevemessick stevemessick deleted the test-regex branch November 9, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwren jwren jwren approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't run testWidget tests individually inside a group
2 participants
@stevemessick @jwren