Convert to Gradle project with Kotlin DSL #5858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevemessick
changed the title
|
This is ready for review. Tests were working; I don't know why they fail now. |
jwren
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a lot of changes have been made, but most of the work is in the Gradle scripts. The project has two sub-modules, one for IntelliJ (flutter-idea) and one for Android Studio (flutter-studio).
srctoflutter-ideatestSrctoflutter-ideagen/iconstoflutter-idea/srcthird_partytoflutter-ideaUpdate
build.gradle,flutter-idea/build.gradle, andflutter-studio/build.gradleaccordingly, then rename to Kotlin DSL files (added *.kt). The biggest change probably is deletingflutter-intellij.iml; the project is no longer usable as an old-schoold IntelliJ project. SeeConvert Groovy to Kotlin DSL, commit 878b508.