Skip to content

Update build #5863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Update build #5863

merged 4 commits into from
Nov 19, 2021

Conversation

stevemessick
Copy link
Member

@jwren

Adds a build spec for IntelliJ beta, which does not work (so is dev channel only).

Updates survey URL.

Fixes #5853

@google-cla google-cla bot added the cla: yes label Nov 18, 2021
@stevemessick stevemessick requested a review from jwren November 18, 2021 23:23
@@ -20,12 +20,11 @@
public class FlutterSurveyService {
private static final String FLUTTER_LAST_SURVEY_CONTENT_CHECK_KEY = "FLUTTER_LAST_SURVEY_CONTENT_CHECK_KEY";
private static final long CHECK_INTERVAL_IN_MS = TimeUnit.HOURS.toMillis(40);
private static final String CONTENT_URL = "https://flutter.dev/f/flutter-survey-metadata.json";
private static final String CONTENT_URL = "https://docs.flutter.dev/f/dart-devtools-survey-metadata.json";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IDEs should still be using flutter-survey-metadata.json, so you'll just need to add the docs. here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on survey URL changes

@stevemessick
Copy link
Member Author

Thanks @kenzieschmoll -- I'll merge this today, but will give @jwren a chance to check the beta build spec.

@stevemessick stevemessick merged commit a22560e into master Nov 19, 2021
@stevemessick stevemessick deleted the update-build branch November 19, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work-around for Inspector: The embedded browser failed to load
3 participants