Skip to content

[WIP] Remove non-Flutter projects from NPW #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

stevemessick
Copy link
Member

This removes all project types except Flutter from the new project wizard in Android Studio. One of the concerns the AS group has is that the NPW we are using exposes things that don't make sense for Android.

Old
Screen Shot 2022-01-14 at 2 53 40 PM

New
Screen Shot 2022-01-14 at 3 18 42 PM

This uses the fest library, which is normally used for functional testing. I'm not sure we want to distribute that as part of the plugin, so I'd like to get feedback on whether this seems like a PR we want to keep.

Until recently, I was trimming the project list when the NPW was constructed. Unfortunately, AS locked down the code I was re-using so I had to remove that.

WIP until the build system is modified to work with fest.

@stevemessick
Copy link
Member Author

This PR will be deleted. Due to scheduling constraints it may be a while before anyone gets back to this topic. We do not want to distribute a test library in production code.

What we need to do is use this code to find the project list in the debugger. Then trace the widget tree up to the frame and simply write code to traverse from the frame back to the list. We could even go back to the UI we had where all Flutter project types were shown in the project list, rather than being selected from a drop-down list on the second page.

@stevemessick stevemessick added this to the M66 milestone Feb 2, 2022
@stevemessick stevemessick deleted the trim-projects branch July 10, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant