Skip to content

Add Short super.key #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 30, 2023
Merged

Add Short super.key #6757

merged 13 commits into from
May 30, 2023

Conversation

MohamedIO
Copy link
Contributor

No description provided.

@MohamedIO MohamedIO changed the title Short super.key Add material.dart import and Short super.key May 18, 2023
@MohamedIO MohamedIO changed the title Add material.dart import and Short super.key Add Short super.key May 18, 2023
@stevemessick
Copy link
Member

@jacob314 @anderdobo We had been holding off making this change (super.key constructors) because it is incompatible with older language versions. With Dart 3 out, is it safe to make this change now?

@DevBlooming assuming the answer to the above question is "yes" then please update the AUTHORS file or let me know you don't want to.

@stevemessick
Copy link
Member

@jacob314 @anderdobo The other way to ask my question is: Do we need to support these code-generating templates for Dart SDKs prior to 2.17.0-0?

@MohamedIO
Copy link
Contributor Author

@stevemessick AUTHORS file updated.

@stevemessick stevemessick self-requested a review May 30, 2023 17:05
@stevemessick stevemessick merged commit e738af5 into flutter:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevemessick stevemessick stevemessick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MohamedIO @stevemessick