Skip to content

🚸 Add device name for running processes #6774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

🚸 Add device name for running processes #6774

merged 1 commit into from
Jun 1, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented May 31, 2023 •
edited
Loading

Resolves #6189 (comment).

image
image
image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@AlexV525 AlexV525 changed the title 🚸 Use reflection to update RunContentDescriptor.myDisplayName 🚸 Add device name for running processes May 31, 2023
@stevemessick
Copy link
Member

@AlexV525 Does this also change the debugger tab name?

@AlexV525
Copy link
Member Author

AlexV525 commented Jun 1, 2023 •
edited
Loading

@AlexV525 Does this also change the debugger tab name?

Yes indeed. Added a related screenshot in the top comment.

@stevemessick stevemessick self-requested a review June 1, 2023 15:03
@stevemessick stevemessick merged commit 14a056b into flutter:master Jun 1, 2023
@AlexV525 AlexV525 deleted the feat/add-device-name-to-run-content-descriptor branch June 1, 2023 15:06
@AlexV525 AlexV525 mentioned this pull request Feb 21, 2025
Merged
8 tasks
jwren pushed a commit that referenced this pull request Apr 11, 2025
@AlexV525
♻️ Add back the device name with the running tab (#7948)
a6abe92 
Recovers the ability of
#6774.
Fixes #7605
Fixes #7539 

`myDisplayName` no longer exists in the
`com.intellij.execution.ui.RunContentDescriptor`, it has been replaced
by a `MutableReactiveProperty` `myDisplayNameView` since 2024 builds.

[2024+
`myDisplayNameView`](https://github.com/JetBrains/intellij-community/blob/idea/231.8109.175/platform/execution/src/com/intellij/execution/ui/RunContentDescriptor.java#L30)
[2023
`myDisplayName`](https://github.com/JetBrains/intellij-community/blob/idea/241.14494.240/platform/execution/src/com/intellij/execution/ui/RunContentDescriptor.java#L33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevemessick stevemessick stevemessick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Embedding DevTools] Support switch between multiple running devices in the Inspector
2 participants
@AlexV525 @stevemessick