Skip to content

Add updated new UI icons and mappings #7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Add updated new UI icons and mappings #7574

merged 3 commits into from
Jul 30, 2024

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Jul 24, 2024

This is following guidance from https://plugins.jetbrains.com/docs/intellij/icons.html#new-ui-icons and removes the need for us to toggle icon changes on light/dark mode or compact vs. normal mode.

Light:
Screenshot 2024-07-30 at 12 42 51 PM

Dark:
Screenshot 2024-07-30 at 12 43 00 PM

Compact light:
Screenshot 2024-07-30 at 12 43 22 PM

Compact dark:
Screenshot 2024-07-30 at 12 43 12 PM

@helin24 helin24 marked this pull request as ready for review July 30, 2024 19:45
@helin24 helin24 requested review from jwren and kenzieschmoll July 30, 2024 19:45
@helin24 helin24 mentioned this pull request Jul 30, 2024
@helin24 helin24 merged commit b2a6a2b into flutter:master Jul 30, 2024
7 checks passed
@helin24 helin24 deleted the icons branch July 30, 2024 20:20
@c5inco
Copy link

c5inco commented Aug 27, 2024

Have you actually tried these icons at runtime? I ask because it looks like you are using some shades of blue that don't exactly match the IntelliJ icon color palette, which can be an issue on the active selected state on a tool window since it may not fully turn the icon white and result in blue on blue background.

@c5inco
Copy link

c5inco commented Aug 27, 2024

Ah yeah, this issue has already been reported: #7621

@helin24
Copy link
Member Author

helin24 commented Aug 30, 2024

@c5inco thanks, I'll see if I can change to using the standard icon color palette. Where can I find what colors are part of the IntelliJ palette?

Never mind, I suspect it's in here and I've requested access to figma to open it.

@helin24
Copy link
Member Author

helin24 commented Sep 3, 2024

@c5inco When I'm choosing a color for icons, does being "standard" mean that the color has to be noted as being relevant for icons? For example, should I be able to use Blues 1-3, or only Blue 4 in an icon? I seem to be getting inconsistent results when I'm testing: blue 4 always works, but blue 1-3 sometimes works and sometimes doesn't.

Screenshot 2024-08-31 at 7 03 22 PM

@c5inco
Copy link

c5inco commented Sep 5, 2024

Yes the color palette can be found in the Int UI Kit Community file.

And yes, you should be using colors that the palette descriptions describe as being used. So to your example, yes, when using Blue, you need to use Blue4 (for light theme) and the other for dark theme (can't recall at the moment what it i s). This should be noted in the Figma file.

It's also helpful to look at the colors used in the Int UI Icons Community file which shows the larger range of colors you can use, that should map as well.

@helin24
Copy link
Member Author

helin24 commented Sep 5, 2024

Thanks for the advice! I believe I'm using the right colors now, but I get inconsistent results on hover.

There are five custom icons here below the selected icon:
Screenshot 2024-09-05 at 9 19 43 AM

Out of these, icons 2 and 3 exhibit the correct behavior on selection, e.g.:
Screenshot 2024-09-05 at 9 21 25 AM

Icons 1, 4, and 5 don't become white on selection, e.g.:
Screenshot 2024-09-05 at 9 21 52 AM

All five are using a combination of gray 6 (#6C707E) and blue 4 (#3574F0). Are there other factors besides color that determine whether the icon turns white on selection?

@c5inco
Copy link

c5inco commented Sep 6, 2024

Tool window icons only tint to white on active selection (since the background turns to the accent blue). For other states like hover or inactive selection, it doesn't tint to white in order to maintain contrast with the respective state backgrounds (shades of gray).

@helin24
Copy link
Member Author

helin24 commented Sep 6, 2024

Thanks! I think I was in the state of inactive selection due to some of these tool windows not truly being initialized until an app was running. This works as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants