Make performance tab warning text red #7581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwren may know if there is an accessible error / warning color that is used elsewhere in the IntelliJ plugin that we could re-use here (the current red may be a bit jarring), but generally LGTM. For example, maybe the same red we use to show the janky frames in the FPS chart? |
kenzieschmoll
approved these changes
Jul 29, 2024
|
I updated to be a less obnoxious shade of red, which we use in light mode for the bars in the performance page: 
This one seems reasonable for both light and dark mode so I'll go with this color. |
|
Change LGTM, this is temporary code. The difference in the color red is fine with me as the point is to draw attention to it. |
jwren
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7577