Use standard icon colors so that selected icons are white #7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the Blue looks more like Flutter colors than the Teal. |
|
Okay, I'll switch to blue then. Plus it's a little weird to be using blue for light mode and then teal for dark mode. |
jwren
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the colors of the Flutter insets within the SVG files. The light icons did not change much, because the blue used before was pretty close to the standard blue.
The dark versions' Flutter insets were previously an aqua shade, and I'm not sure if it would be better to change to teal or blue. For now I've chosen teal because it seemed a little brighter, but neither seems ideal. For reference, the colors are coming from https://www.figma.com/design/jYJmUxEUdob9FxsCxfRTDb/Int-UI-Kit-(Community) and we can use the colors that are identified as being for icons.
Fixes #7621