Skip to content

Add a flutter pub add action #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Add a flutter pub add action #7924

merged 5 commits into from
Feb 4, 2025

Conversation

jakemac53
Copy link
Contributor

Opening in case we are interesting in actually upstreaming this - I mostly just did it to get familiar with how actions are set up and plumbed through.

Using the action opens a dialog like this:

Screenshot 2025-02-04 at 1 16 26 PM

It does do some validation that a non-empty package name was input, but that is it today:

Screenshot 2025-02-04 at 1 16 59 PM

And it does ensure you actually clicked "OK" before actually running any commands.

@jakemac53 jakemac53 requested a review from jwren February 4, 2025 21:18
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Revert out the gradle.properties changes. Also, you'll have to run ./bin/plugin generate to get the github presubmit action to pass.

@jakemac53
Copy link
Contributor Author

Revert out the gradle.properties changes. Also, you'll have to run ./bin/plugin generate to get the github presubmit action to pass.

Done 👍

@jakemac53 jakemac53 merged commit 78f85d4 into flutter:master Feb 4, 2025
9 checks passed
@jakemac53 jakemac53 deleted the pub-add branch February 4, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants