Skip to content

[CQ] remove redundant throws #8140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

[CQ] remove redundant throws #8140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter-idea/src/io/flutter/view/EmbeddedBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ private BrowserTab openBrowserTabFor(String tabName, ToolWindow toolWindow) thro
return tab;
}

public abstract EmbeddedTab openEmbeddedTab(ContentManager contentManager) throws Exception;
public abstract EmbeddedTab openEmbeddedTab(ContentManager contentManager);

public void updatePanelToWidget(String widgetId) {
updateUrlAndReload(devToolsUrl -> {
Expand Down
5 changes: 3 additions & 2 deletions flutter-idea/src/io/flutter/view/EmbeddedJcefBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ public void matchIdeZoom() {

@Override
public JComponent getTabComponent(ContentManager contentManager) {
browser.getComponent().setPreferredSize(new Dimension(contentManager.getComponent().getWidth(), contentManager.getComponent().getHeight()));
browser.getComponent()
.setPreferredSize(new Dimension(contentManager.getComponent().getWidth(), contentManager.getComponent().getHeight()));
return browser.getComponent();
}
}
Expand All @@ -62,7 +63,7 @@ public Logger logger() {
}

@Override
public EmbeddedTab openEmbeddedTab(ContentManager contentManager) throws Exception {
public EmbeddedTab openEmbeddedTab(ContentManager contentManager) {
return new EmbeddedJcefBrowserTab();
}
}