Revert deletion of deploy command to fix dev build #8155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 140f16c.
|
LGTM, CC @pq who removed this after a conversation we had. I did not know at the time that Kokoro uses the |
jwren
approved these changes
May 6, 2025
|
This is great to know. Thanks for the fix and for looping me in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should fix the dev build, which stopped uploading back in February. It uses the command
./bin/plugin deploy --channel=dev(seetool/kokoro/deploy.sh). The deletion happened in #7929.I can't test it from an internal command until these changes are in the main branch though.
It could be we no longer need the dev build, but this seems like an easy enough change.