Skip to content

Fix iOS button enabled for no preview #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

leontobias
Copy link
Contributor

@leontobias leontobias commented Nov 1, 2022

I have updated the behavior where the asset picker for iOS would still show the confirm button in the bottom app bar even if isSingleAssetMode == true and isPreviewEnabled == false.

I assume this to be a bug as:

  1. Android is behaving different (as expected)
  2. Inside appleOSLayout I assume the isAppleOS check is unneeded

If suitable, please let me know whether this needs a changelog entry and which formatting requirements this has.

closes #377

@AlexV525
Copy link
Member

AlexV525 commented Nov 2, 2022

Thanks for fixing this. Something should be indicated before the review.

  • The behavior should be the same as Android, only with the different position.
  • Tests should be added, and we had tests against the confirm button on Android already so it'll be easy to write a new one.
  • CHANGELOG.md, pubspec.yaml and example.yaml should be updated correspondingly.

@AlexV525 AlexV525 merged commit e7dea8f into fluttercandies:main Nov 8, 2022
@AlexV525
Copy link
Member

AlexV525 commented Nov 8, 2022

@all-contributors Add @leonpesdk for bugs.

@allcontributors
Copy link
Contributor

@AlexV525

I've put up a pull request to add @leonpesdk! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] iOS confirm button still visible if preview not enabled
2 participants