-
-
Notifications
You must be signed in to change notification settings - Fork 478
New custom insta delegate #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New custom insta delegate #403
Conversation
…nstaAssetPickerBuilder` preview asset
…ickerViewer.didUpdateWidget Co-authored-by: Alex Li <[email protected]>
I run the example with the new delegate and delete the |
Here i recorded my screen while reproducing the error. Basically when the Screen.Recording.2022-12-30.at.2.26.45.PM.mov |
I've split the |
The exception seems to be gone! Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Although I do found some strange behavior when scrolling the picker, but I think I'll try to update them and submit issues to your picker if possible.
Great! Sure, if you find any issue let me know via the insta_assets_picker repository, i will try to fix it there and apply it in the delegate example as well. |
As we discussed previously #399.
Introduce
InstaAssetPickerBuilder
based on insta_assets_picker which reproduces instagram layout.This custom delegate show how to:
keepScrollOffset
when set to true to restore scroll and previewDefaultAssetPickerViewerBuilderDelegate
(currently there is no example for it)Tested on both iOS and Android.
Changes needed outside of example folder
AssetPickerViewer
, when not used in a new pushed route,initStateAndTicker
would be omitted.Record
RPReplay_Final1672293966-3.mov