Skip to content

Semantics with Vietnamese #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2023
Merged

Semantics with Vietnamese #424

merged 6 commits into from
Apr 23, 2023

Conversation

nploi
Copy link
Contributor

@nploi nploi commented Apr 5, 2023

Hi team,
I want support Vietnamese language for this package, please review it.
Thank you.

@nploi
Copy link
Contributor Author

nploi commented Apr 13, 2023

hi @AlexV525 can you help review this one ? thank you!

@AlexV525
Copy link
Member

@nploi Thanks for the new language support. Generally adding language support will require providing a screen record with TalkBack or VoiceOver enabled to see if those fields play well in the accessibility mode.

@nploi
Copy link
Contributor Author

nploi commented Apr 14, 2023

@nploi Thanks for the new language support. Generally adding language support will require providing a screen record with TalkBack or VoiceOver enabled to see if those fields play well in the accessibility mode.

okay, i will update that soon.

@nploi
Copy link
Contributor Author

nploi commented Apr 21, 2023

Hi @AlexV525, i have a short record with TalkBack.

record.mp4

@AlexV525
Copy link
Member

The text delegate and the semantics LGTM. Please also add a CHANGELOG entry and update the pubspec too.

@nploi
Copy link
Contributor Author

nploi commented Apr 22, 2023

The text delegate and the semantics LGTM. Please also add a CHANGELOG entry and update the pubspec too.

Done @AlexV525.

@AlexV525 AlexV525 merged commit d8736fb into fluttercandies:main Apr 23, 2023
@AlexV525 AlexV525 mentioned this pull request Apr 23, 2023
Closed
@nploi nploi deleted the Vietnamese-lang-support branch April 23, 2023 10:35
@AlexV525 AlexV525 mentioned this pull request Apr 23, 2023
Merged
@AlexV525
Copy link
Member

AlexV525 commented May 1, 2023

@all-contributors Add @nploi for internationalization.

@allcontributors
Copy link
Contributor

@AlexV525

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@AlexV525
Copy link
Member

AlexV525 commented May 1, 2023

@all-contributors Add @nploi for translation.

@allcontributors allcontributors bot mentioned this pull request May 1, 2023
Merged
@allcontributors
Copy link
Contributor

@AlexV525

I've put up a pull request to add @nploi! 🎉

AlexV525 pushed a commit that referenced this pull request May 1, 2023
@allcontributors
docs: add nploi as a contributor for translation (#437)
f7fc9fb 
Adds @nploi as a contributor for translation.

This was requested by AlexV525 [in this
comment](#424 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nploi @AlexV525