Skip to content

🚀 Expand FilterOptionGroup to PMFilter #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2023
Merged

🚀 Expand FilterOptionGroup to PMFilter #436

merged 2 commits into from
May 5, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented May 1, 2023

No description provided.

@AlexV525 AlexV525 marked this pull request as ready for review May 1, 2023 03:33
@AlexV525 AlexV525 merged commit 58b0468 into main May 5, 2023
@AlexV525 AlexV525 deleted the allow-pm-filter branch May 5, 2023 07:55
xsq007
xsq007 reviewed May 6, 2023
View reviewed changes
Copy link

@xsq007 xsq007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If filterOptions is other PMFilter subtype, e.g. AdvancedCustomFilter, filterOptions value is ignored and doesn't take effect any more.

@AlexV525
Copy link
Member Author

AlexV525 commented May 6, 2023

@xsq007 Good catch! I merged those options in a opposite way which cause the mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsq007 xsq007 xsq007 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @xsq007