Skip to content

Use the verify defined interface in OCIRepository #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2024
Merged

Use the verify defined interface in OCIRepository #1417

merged 2 commits into from
Mar 27, 2024

Conversation

souleb
Copy link
Member

@souleb souleb commented Mar 26, 2024

This makes the use of the verifier consistent between providers.

darkowlzz
darkowlzz approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the cosign implementation. Reads much better now.
LGTM!

Left a minor suggestion for further simplification which can be considered or ignored.

stefanprodan
stefanprodan approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb

@stefanprodan stefanprodan added the area/oci OCI related issues and pull requests label Mar 27, 2024
@souleb souleb merged commit 295fb73 into main Mar 27, 2024
@souleb souleb deleted the switch-to-verify-ocirepo branch March 27, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/oci OCI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@souleb @darkowlzz @stefanprodan