Update artifact tarball when spec.ignore changes
#710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new field `status.artifact.excludedPatternsChecksum` which is used to detect changes on `spec.ignore`, that controls the exclusions for the object's `status.artifact`. Signed-off-by: Tiago Angelo <[email protected]>
1 task
hiddeco
reviewed
May 6, 2022
| // ExcludedPatternsChecksum is a SHA256 checksum of the excluded patterns | ||
| // applied in the last reconciliation. | ||
| // +optional | ||
| ExcludedPatternsChecksum string `json:"excludedPatternsChecksum,omitempty"` |
There was a problem hiding this comment.
Not every object is making use of exclusions. Given this, I do not think this field should be added to the Artifact, but rather to the Status objects from the Bucket and GitRepository.
In addition, I do not think that the new term ExcludedPatterns should be introduced. I would rather call it IgnoreChecksum or ObservedIgnore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field
status.artifact.excludedPatternsChecksumwhich is used to detect changes onspec.ignore, that controls the exclusions for the object'sstatus.artifact.