Skip to content

OCIRepository client cert auth #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

rashedkvm
Copy link
Member

@rashedkvm rashedkvm commented Jul 8, 2022

Signed-off-by: Rashed Kamal [email protected]

Implements

spec:
  certSecretRef:
    name: regcert

The certSecretRef points to a Kubernetes secret in the same namespace as the OCIRepository:

When parsing secret referenced by certSecretRef, the following keys are used

certFile=client.crt
keyFile=client.key
caFile=ca.crt

Example secret:

kubectl create secret generic regcert \
  --from-file=certFile=client.crt \
  --from-file=keyFile=client.key \
  --from-file=caFile=ca.crt

resolves #814

@rashedkvm rashedkvm marked this pull request as ready for review July 8, 2022 04:19
@pjbgf pjbgf added this to the GA milestone Jul 8, 2022
@pjbgf pjbgf added the area/oci OCI related issues and pull requests label Jul 8, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @rashedkvm 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oci OCI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants