Minor fixes to sorting documentation #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the documentation did not mention character(len=*) or type(string_type)
Sorting documentation fixes
|
Thank you @gareth-nx. I noticed similar issues (that I didn't see during the review) at some places. Could I open a PR with my changes against your branch, such that we have only this PR against fortran-lang:master? |
|
Yes that would be great. I'm not too familiar with git pull requests, so if
you can push ahead without needing me to interact via git, that would be
easiest for me.
…On Fri, 4 Jun 2021, 02:10 Jeremie Vandenplas, ***@***.***> wrote:
Thank you @gareth-nx <https://github.com/gareth-nx>. I noticed similar
issues (that I didn't see during the review) at some places. Could I open a
PR with my changes against your branch, such that we have only this PR
against fortran-lang:master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#422 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATV4V2LENDSO3LJVSAY32CTTQ6SQDANCNFSM46A2XAJQ>
.
|
Thank you @gareth-nx . I openedd a PR here. If you merge it, my changes will also appear in this PR. |
Mainly added some links
|
Done, thankyou |
|
Thank you @gareth-nx for spotting and correcting the specs. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the documentation were missing references to sorting character(len=*) or type(string_type) -- but these are supported.