Make maximum rank an option #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
awvwgk
commented
Jun 22, 2021
awvwgk
commented
- set default value of 4 to reduce compilation load
- set default value of 4 to reduce compilation load
jvdp1
approved these changes
Jun 23, 2021
| @@ -127,7 +127,8 @@ Important options are | |||
| - `-G Ninja` to use the Ninja backend instead of the default Make backend. Other build backends are available with a similar syntax. | |||
| - `-DCMAKE_INSTALL_PREFIX` is used to provide the install location for the library. | |||
| - `-DCMAKE_MAXIMUM_RANK` the maximum array rank procedures should be generated for. | |||
| The default is 15 for Fortran 2003 compliant compilers, otherwise 7 for compilers not supporting Fortran 2003 completely yet. | |||
| The default value is chosen as 4. | |||
There was a problem hiding this comment.
Suggested change
| The default value is chosen as 4. | |
| The default value is chosen as 4, which is also the minimum required rank to compile this project. |
To delete: line 132<
There was a problem hiding this comment.
This is mentioned in the next sentence already.
There was a problem hiding this comment.
Yes, I know. I propose to combine them ;) So the next one should be deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.