use "select case" for clarity/brevity #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milancurcic
approved these changes
Jan 5, 2020
jvdp1
reviewed
Jan 5, 2020
| @@ -300,51 +300,53 @@ integer function open(filename, mode) result(u) | |||
|
|
|||
| mode_ = parse_mode(optval(mode, "")) | |||
|
|
|||
| if (mode_(1:2) == 'r ') then | |||
| select case (mode_(1:2)) | |||
There was a problem hiding this comment.
It looks cleaner with select case.
However, I usually avoid to use select case with character since I got memory issues (leaks) with Intel Fortran compiler. Any of you observed such issues?
There was a problem hiding this comment.
If there are leaks, then we'll revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
select casehere is clearer since the condition doesn't need to include spaces, and brieferalso add "pure" where suitable