Conversion functions from degrees to radians and vice-versa. #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalvesz
requested changes
Jul 3, 2024
perazz
reviewed
Jul 3, 2024
Co-authored-by: Federico Perini <[email protected]>
Co-authored-by: Federico Perini <[email protected]>
Co-authored-by: Federico Perini <[email protected]>
Co-authored-by: Federico Perini <[email protected]>
perazz
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Thank you @MilanSkocic. LGTM with the edits and I think it is a useful addition. I would wait for an additional opinion from @jalvesz and @jvdp1.
jvdp1
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
LGTM. Thank you @MilanSkocic . Pending minor comments, changes, this PR can be merged IMO.
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
jvdp1
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
Thank you @MilanSkocic . IMO it is good to be merged. Let wait a couple of days for other potential comments/reviews.
|
LGTM @MilanSkocic thanks for this nice addition!! |
|
Thank you @MilanSkocic for this addition. I will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #837, I implemented:
deg2radandrad2deginstdlib_mathResolves #837