Skip to content

Resolve internal variables in formatter arguments #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Resolve internal variables in formatter arguments #1171

merged 1 commit into from
Mar 1, 2025

Conversation

zandivx
Copy link
Contributor

@zandivx zandivx commented Jan 31, 2025

Currently, VS Code variables like ${workspaceFolder} are not expanded in the arguments provided to the selected formatter. As this functionality is already implemented in this project and applied at several places, it's no effort to apply it to the arguments for the formatter as well.

@krystophny
Copy link

Thanks @zandivx ! This enables the use of a .fprettify file in the workspace folder

    "fortran.formatting.fprettifyArgs": [
        "--config",
        "${workspaceFolder}/.fprettify"
    ],

@gnikit this is a small change that is very useful, if you find time we would be very grateful if you could review this.

@zandivx
Copy link
Contributor Author

zandivx commented Mar 1, 2025

@gnikit Perhaps you find time to review this change, it would be really convenient to be able to use this feature. It's just the usage of existing functionality in another place, no big changes introduced.
Thanks in advance!

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (4deaf57) to head (a2f55e8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   81.28%   81.30%   +0.01%     
==========================================
  Files          12       12              
  Lines        2319     2321       +2     
  Branches      191      191              
==========================================
+ Hits         1885     1887       +2     
  Misses        429      429              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnikit gnikit merged commit 4bf2c6e into fortran-lang:main Mar 1, 2025
3 checks passed
@gnikit
Copy link
Member

gnikit commented Mar 1, 2025

Done @zandivx. Thanks for the contribution and the bug fix! I have issued a Nightly release to you can download the pre-release and have the fix available.

@zandivx
Copy link
Contributor Author

zandivx commented Mar 1, 2025

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants