Skip to content

Bump, widen and fix setuptools dependency #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Apr 22, 2025

Also prepare release notes for the v0.13.3 release.

@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 12:43
@llucax llucax requested a review from a team as a code owner April 22, 2025 12:43
@llucax llucax requested a review from shsms April 22, 2025 12:43
@github-actions github-actions bot added the part:template Affects the cookiecutter template files label Apr 22, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions and boundaries for setuptools and its related packages, ensuring consistency across different dependency groups, and prepares release notes for v0.13.3.

  • Bumped setuptools and setuptools_scm versions in the build-system.
  • Widened setuptools version boundaries in the API and development dependencies.
  • Adjusted cookiecutter template configuration for pytest and mkdocs.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated dependency versions and version ranges for setuptools.
cookiecutter/{{cookiecutter.github_repo_name}}/pyproject.toml Reordered conditional blocks in pytest configuration.
cookiecutter/{{cookiecutter.github_repo_name}}/mkdocs.yml Modified mkdocstrings configuration, including renaming the key.
Comments suppressed due to low confidence (1)

cookiecutter/{{cookiecutter.github_repo_name}}/mkdocs.yml:119

  • The configuration key for external references was changed from 'import:' to 'inventories:'. Please verify if this change is intentional and update the associated comment to reflect the new key if needed.
inventories:

@llucax llucax requested a review from Copilot April 22, 2025 12:46
@github-actions github-actions bot added part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Apr 22, 2025
@llucax llucax self-assigned this Apr 22, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency requirements for setuptools and setuptools_scm in the build and project settings and simplifies the release notes for the v0.13.3 release.

  • Updated build-system dependencies to "setuptools == 79.0.0" and "setuptools_scm[toml] == 8.3.0".
  • Widened the version ranges for setuptools and types-setuptools to allow up to version 80.
  • Simplified RELEASE_NOTES.md to reflect the dependency update.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated dependency versions and widened version ranges for consistency across sections.
RELEASE_NOTES.md Condensed release notes to document the dependency update for the v0.13.3 release.
Comments suppressed due to low confidence (1)

pyproject.toml:60

  • Ensure the updated upper bound for setuptools (< 80) is consistently applied across all dependency sections and that related comments are updated to reflect this change.
  "setuptools >= 67.6.0, < 80",

@llucax llucax added this to the v0.13.3 milestone Apr 22, 2025
@llucax llucax enabled auto-merge April 22, 2025 12:46
@llucax
Copy link
Contributor Author

llucax commented Apr 23, 2025

Will force-merge as it is pretty trivial and most people is away this week.

@llucax llucax disabled auto-merge April 23, 2025 08:36
@llucax llucax merged commit 3fbbfd8 into frequenz-floss:v0.x.x Apr 23, 2025
5 checks passed
@llucax llucax deleted the setuptools-80 branch April 23, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:docs Affects the documentation part:template Affects the cookiecutter template files part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant